Merge pull request #9 from alexmickelson/copilot/fix-8

Add quiz question order verification after Canvas import

src/features/canvas/services/canvasQuizService.test.ts

@@ -0,0 +1,225 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { canvasQuizService } from "./canvasQuizService";
+import { CanvasQuizQuestion } from "@/features/canvas/models/quizzes/canvasQuizQuestionModel";
+import { LocalQuiz } from "@/features/local/quizzes/models/localQuiz";
+import { QuestionType } from "@/features/local/quizzes/models/localQuizQuestion";
+
+// Mock the dependencies
+vi.mock("@/services/axiosUtils", () => ({
+  axiosClient: {
+    get: vi.fn(),
+    post: vi.fn(),
+    delete: vi.fn(),
+  },
+}));
+
+vi.mock("./canvasServiceUtils", () => ({
+  canvasApi: "https://test.instructure.com/api/v1",
+  paginatedRequest: vi.fn(),
+}));
+
+vi.mock("./canvasAssignmentService", () => ({
+  canvasAssignmentService: {
+    getAll: vi.fn(() => Promise.resolve([])),
+    delete: vi.fn(() => Promise.resolve()),
+  },
+}));
+
+vi.mock("@/services/htmlMarkdownUtils", () => ({
+  markdownToHTMLSafe: vi.fn(({ markdownString }) => `<p>${markdownString}</p>`),
+}));
+
+vi.mock("@/features/local/utils/timeUtils", () => ({
+  getDateFromStringOrThrow: vi.fn((dateString) => new Date(dateString)),
+}));
+
+vi.mock("@/services/utils/questionHtmlUtils", () => ({
+  escapeMatchingText: vi.fn((text) => text),
+}));
+
+describe("canvasQuizService", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  describe("getQuizQuestions", () => {
+    it("should fetch and sort quiz questions by position", async () => {
+      const mockQuestions: CanvasQuizQuestion[] = [
+        {
+          id: 3,
+          quiz_id: 1,
+          position: 3,
+          question_name: "Question 3",
+          question_type: "multiple_choice_question",
+          question_text: "What is 2+2?",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+        {
+          id: 1,
+          quiz_id: 1,
+          position: 1,
+          question_name: "Question 1",
+          question_type: "multiple_choice_question",
+          question_text: "What is your name?",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+        {
+          id: 2,
+          quiz_id: 1,
+          position: 2,
+          question_name: "Question 2",
+          question_type: "essay_question",
+          question_text: "Describe yourself",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+      ];
+
+      const { paginatedRequest } = await import("./canvasServiceUtils");
+      vi.mocked(paginatedRequest).mockResolvedValue(mockQuestions);
+
+      const result = await canvasQuizService.getQuizQuestions(1, 1);
+
+      expect(result).toHaveLength(3);
+      expect(result[0].position).toBe(1);
+      expect(result[1].position).toBe(2);
+      expect(result[2].position).toBe(3);
+      expect(result[0].question_text).toBe("What is your name?");
+      expect(result[1].question_text).toBe("Describe yourself");
+      expect(result[2].question_text).toBe("What is 2+2?");
+    });
+
+    it("should handle questions without position", async () => {
+      const mockQuestions: CanvasQuizQuestion[] = [
+        {
+          id: 1,
+          quiz_id: 1,
+          question_name: "Question 1",
+          question_type: "multiple_choice_question",
+          question_text: "What is your name?",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+        {
+          id: 2,
+          quiz_id: 1,
+          question_name: "Question 2",
+          question_type: "essay_question",
+          question_text: "Describe yourself",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+      ];
+
+      const { paginatedRequest } = await import("./canvasServiceUtils");
+      vi.mocked(paginatedRequest).mockResolvedValue(mockQuestions);
+
+      const result = await canvasQuizService.getQuizQuestions(1, 1);
+
+      expect(result).toHaveLength(2);
+      // Should maintain original order when no position is specified
+    });
+  });
+
+  describe("Question order verification (integration test concept)", () => {
+    it("should detect correct question order", async () => {
+      // This is a conceptual test showing what the verification should validate
+      const _localQuiz: LocalQuiz = {
+        name: "Test Quiz",
+        description: "A test quiz",
+        dueAt: "2023-12-01T23:59:00Z",
+        shuffleAnswers: false,
+        showCorrectAnswers: true,
+        oneQuestionAtATime: false,
+        allowedAttempts: 1,
+        questions: [
+          {
+            text: "What is your name?",
+            questionType: QuestionType.SHORT_ANSWER,
+            points: 5,
+            answers: [],
+            matchDistractors: [],
+          },
+          {
+            text: "Describe yourself",
+            questionType: QuestionType.ESSAY,
+            points: 10,
+            answers: [],
+            matchDistractors: [],
+          },
+          {
+            text: "What is 2+2?",
+            questionType: QuestionType.MULTIPLE_CHOICE,
+            points: 5,
+            answers: [
+              { text: "3", correct: false },
+              { text: "4", correct: true },
+              { text: "5", correct: false },
+            ],
+            matchDistractors: [],
+          },
+        ],
+      };
+
+      const canvasQuestions: CanvasQuizQuestion[] = [
+        {
+          id: 1,
+          quiz_id: 1,
+          position: 1,
+          question_name: "Question 1",
+          question_type: "short_answer_question",
+          question_text: "<p>What is your name?</p>",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+        {
+          id: 2,
+          quiz_id: 1,
+          position: 2,
+          question_name: "Question 2",
+          question_type: "essay_question",
+          question_text: "<p>Describe yourself</p>",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+        {
+          id: 3,
+          quiz_id: 1,
+          position: 3,
+          question_name: "Question 3",
+          question_type: "multiple_choice_question",
+          question_text: "<p>What is 2+2?</p>",
+          correct_comments: "",
+          incorrect_comments: "",
+          neutral_comments: "",
+        },
+      ];
+
+      // Mock the getQuizQuestions to return our test data
+      const { paginatedRequest } = await import("./canvasServiceUtils");
+      vi.mocked(paginatedRequest).mockResolvedValue(canvasQuestions);
+
+      const result = await canvasQuizService.getQuizQuestions(1, 1);
+
+      // Verify the questions are in the expected order
+      expect(result).toHaveLength(3);
+      expect(result[0].question_text).toContain("What is your name?");
+      expect(result[1].question_text).toContain("Describe yourself");
+      expect(result[2].question_text).toContain("What is 2+2?");
+
+      // Verify positions are sequential
+      expect(result[0].position).toBe(1);
+      expect(result[1].position).toBe(2);
+      expect(result[2].position).toBe(3);
+    });
+  });
+});

src/features/canvas/services/canvasQuizService.ts

@@ -89,6 +89,68 @@ const hackFixQuestionOrdering = async (
   await axiosClient.post(url, { order });
 };
 
+const verifyQuestionOrder = async (
+  canvasCourseId: number,
+  canvasQuizId: number,
+  localQuiz: LocalQuiz
+): Promise<boolean> => {
+  console.log("Verifying question order in Canvas quiz");
+  
+  try {
+    const canvasQuestions = await canvasQuizService.getQuizQuestions(
+      canvasCourseId,
+      canvasQuizId
+    );
+
+    // Check if the number of questions matches
+    if (canvasQuestions.length !== localQuiz.questions.length) {
+      console.error(
+        `Question count mismatch: Canvas has ${canvasQuestions.length}, local quiz has ${localQuiz.questions.length}`
+      );
+      return false;
+    }
+
+    // Verify that questions are in the correct order by comparing text content
+    // We'll use a simple approach: strip HTML tags and compare the core text content
+    const stripHtml = (html: string): string => {
+      return html.replace(/<[^>]*>/g, '').trim();
+    };
+
+    for (let i = 0; i < localQuiz.questions.length; i++) {
+      const localQuestion = localQuiz.questions[i];
+      const canvasQuestion = canvasQuestions[i];
+      
+      const localQuestionText = localQuestion.text.trim();
+      const canvasQuestionText = stripHtml(canvasQuestion.question_text).trim();
+
+      // Check if the question text content matches (allowing for HTML conversion differences)
+      if (!canvasQuestionText.includes(localQuestionText) && 
+          !localQuestionText.includes(canvasQuestionText)) {
+        console.error(
+          `Question order mismatch at position ${i}:`,
+          `Local: "${localQuestionText}"`,
+          `Canvas: "${canvasQuestionText}"`
+        );
+        return false;
+      }
+
+      // Verify position is correct
+      if (canvasQuestion.position !== undefined && canvasQuestion.position !== i + 1) {
+        console.error(
+          `Question position mismatch at index ${i}: Canvas position is ${canvasQuestion.position}, expected ${i + 1}`
+        );
+        return false;
+      }
+    }
+
+    console.log("Question order verification successful");
+    return true;
+  } catch (error) {
+    console.error("Error during question order verification:", error);
+    return false;
+  }
+};
+
 const hackFixRedundantAssignments = async (canvasCourseId: number) => {
   console.log("hack fixing redundant quiz assignments that are auto-created");
   const assignments = await canvasAssignmentService.getAll(canvasCourseId);
@@ -137,6 +199,19 @@ const createQuizQuestions = async (
     questionAndPositions
   );
   await hackFixRedundantAssignments(canvasCourseId);
+
+  // Verify that the question order in Canvas matches the local quiz order
+  const orderVerified = await verifyQuestionOrder(
+    canvasCourseId,
+    canvasQuizId,
+    localQuiz
+  );
+
+  if (!orderVerified) {
+    console.warn(
+      "Question order verification failed! The quiz was created but the question order may not match the intended order."
+    );
+  }
 };
 
 export const canvasQuizService = {
@@ -165,6 +240,21 @@ export const canvasQuizService = {
     }
   },
 
+  async getQuizQuestions(
+    canvasCourseId: number,
+    canvasQuizId: number
+  ): Promise<CanvasQuizQuestion[]> {
+    try {
+      const url = `${canvasApi}/courses/${canvasCourseId}/quizzes/${canvasQuizId}/questions`;
+      const questions = await paginatedRequest<CanvasQuizQuestion[]>({ url });
+      // Sort by position to ensure correct order
+      return questions.sort((a, b) => (a.position || 0) - (b.position || 0));
+    } catch (error) {
+      console.error("Error fetching quiz questions from Canvas:", error);
+      throw error;
+    }
+  },
+
   async create(
     canvasCourseId: number,
     localQuiz: LocalQuiz,

src/features/canvas/services/quizOrderVerification.integration.test.ts

@@ -0,0 +1,188 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { LocalQuiz } from "@/features/local/quizzes/models/localQuiz";
+import { QuestionType } from "@/features/local/quizzes/models/localQuizQuestion";
+import { DayOfWeek } from "@/features/local/course/localCourseSettings";
+import { AssignmentSubmissionType } from "@/features/local/assignments/models/assignmentSubmissionType";
+
+// Mock the dependencies
+vi.mock("@/services/axiosUtils", () => ({
+  axiosClient: {
+    get: vi.fn(),
+    post: vi.fn(),
+    delete: vi.fn(),
+  },
+}));
+
+vi.mock("./canvasServiceUtils", () => ({
+  canvasApi: "https://test.instructure.com/api/v1",
+  paginatedRequest: vi.fn(),
+}));
+
+vi.mock("./canvasAssignmentService", () => ({
+  canvasAssignmentService: {
+    getAll: vi.fn(() => Promise.resolve([])),
+    delete: vi.fn(() => Promise.resolve()),
+  },
+}));
+
+vi.mock("@/services/htmlMarkdownUtils", () => ({
+  markdownToHTMLSafe: vi.fn(({ markdownString }) => `<p>${markdownString}</p>`),
+}));
+
+vi.mock("@/features/local/utils/timeUtils", () => ({
+  getDateFromStringOrThrow: vi.fn((dateString) => new Date(dateString)),
+}));
+
+vi.mock("@/services/utils/questionHtmlUtils", () => ({
+  escapeMatchingText: vi.fn((text) => text),
+}));
+
+describe("Quiz Order Verification Integration", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  it("demonstrates the question order verification workflow", async () => {
+    // This test demonstrates that the verification step is properly integrated
+    // into the quiz creation workflow
+    
+    const testQuiz: LocalQuiz = {
+      name: "Test Quiz - Order Verification",
+      description: "Testing question order verification",
+      dueAt: "2023-12-01T23:59:00Z",
+      shuffleAnswers: false,
+      showCorrectAnswers: true,
+      oneQuestionAtATime: false,
+      allowedAttempts: 1,
+      questions: [
+        {
+          text: "First Question",
+          questionType: QuestionType.SHORT_ANSWER,
+          points: 5,
+          answers: [],
+          matchDistractors: [],
+        },
+        {
+          text: "Second Question", 
+          questionType: QuestionType.ESSAY,
+          points: 10,
+          answers: [],
+          matchDistractors: [],
+        },
+      ],
+    };
+
+    // Import the service after mocks are set up
+    const { canvasQuizService } = await import("./canvasQuizService");
+    const { axiosClient } = await import("@/services/axiosUtils");
+    const { paginatedRequest } = await import("./canvasServiceUtils");
+
+    // Mock successful quiz creation
+    vi.mocked(axiosClient.post).mockResolvedValueOnce({
+      data: { id: 123, title: "Test Quiz - Order Verification" },
+    });
+
+    // Mock question creation responses
+    vi.mocked(axiosClient.post)
+      .mockResolvedValueOnce({ data: { id: 1, position: 1 } })
+      .mockResolvedValueOnce({ data: { id: 2, position: 2 } });
+
+    // Mock reordering call
+    vi.mocked(axiosClient.post).mockResolvedValueOnce({ data: {} });
+
+    // Mock assignment cleanup (empty assignments)
+    vi.mocked(paginatedRequest).mockResolvedValueOnce([]);
+
+    // Mock the verification call - questions in correct order
+    vi.mocked(paginatedRequest).mockResolvedValueOnce([
+      {
+        id: 1,
+        quiz_id: 123,
+        position: 1,
+        question_name: "Question 1",
+        question_type: "short_answer_question", 
+        question_text: "<p>First Question</p>",
+        correct_comments: "",
+        incorrect_comments: "",
+        neutral_comments: "",
+      },
+      {
+        id: 2,
+        quiz_id: 123,
+        position: 2,
+        question_name: "Question 2",
+        question_type: "essay_question",
+        question_text: "<p>Second Question</p>",
+        correct_comments: "",
+        incorrect_comments: "",
+        neutral_comments: "",
+      },
+    ]);
+
+    // Create the quiz and trigger verification
+    const result = await canvasQuizService.create(12345, testQuiz, {
+      name: "Test Course",
+      canvasId: 12345,
+      assignmentGroups: [],
+      daysOfWeek: [DayOfWeek.Monday, DayOfWeek.Wednesday, DayOfWeek.Friday],
+      startDate: "2023-08-15",
+      endDate: "2023-12-15",
+      defaultDueTime: { hour: 23, minute: 59 },
+      defaultAssignmentSubmissionTypes: [AssignmentSubmissionType.ONLINE_TEXT_ENTRY],
+      defaultFileUploadTypes: [],
+      holidays: [],
+      assets: []
+    });
+
+    // Verify the quiz was created
+    expect(result).toBe(123);
+
+    // Verify that the question verification API call was made
+    expect(vi.mocked(paginatedRequest)).toHaveBeenCalledWith({
+      url: "https://test.instructure.com/api/v1/courses/12345/quizzes/123/questions",
+    });
+
+    // The verification would have run and logged success/failure
+    // In a real scenario, this would catch order mismatches
+  });
+
+  it("demonstrates successful verification workflow", async () => {
+    const { canvasQuizService } = await import("./canvasQuizService");
+    const { paginatedRequest } = await import("./canvasServiceUtils");
+
+    // Mock questions returned from Canvas in correct order
+    vi.mocked(paginatedRequest).mockResolvedValueOnce([
+      {
+        id: 1,
+        quiz_id: 1,
+        position: 1,
+        question_name: "Question 1",
+        question_type: "short_answer_question",
+        question_text: "First question",
+        correct_comments: "",
+        incorrect_comments: "",
+        neutral_comments: "",
+      },
+      {
+        id: 2,
+        quiz_id: 1,
+        position: 2,
+        question_name: "Question 2",
+        question_type: "essay_question",
+        question_text: "Second question",
+        correct_comments: "",
+        incorrect_comments: "",
+        neutral_comments: "",
+      },
+    ]);
+
+    const result = await canvasQuizService.getQuizQuestions(1, 1);
+
+    // Verify questions are returned in correct order
+    expect(result).toHaveLength(2);
+    expect(result[0].position).toBe(1);
+    expect(result[1].position).toBe(2);
+    expect(result[0].question_text).toBe("First question");
+    expect(result[1].question_text).toBe("Second question");
+  });
+});