peace nirvana and no yellow warning lines in my console

This commit is contained in:
2023-12-05 16:33:04 -07:00
parent 6e49c79cbd
commit 91e946c36d
26 changed files with 75 additions and 397 deletions

View File

@@ -37,7 +37,7 @@ public class AssignmentEditorContext
public void SaveAssignment(LocalAssignment newAssignment)
{
if (planner.LocalCourse != null)
if (planner.LocalCourse != null && Assignment != null)
{
// run discovery on Assignment, it was the last stored version of the assignment
var currentModule = getCurrentLocalModule(Assignment, planner.LocalCourse);
@@ -106,7 +106,6 @@ public class AssignmentEditorContext
courseId: (ulong)planner.LocalCourse.Settings.CanvasId,
canvasAssignmentId: canvasAssignmentId,
localAssignment: Assignment,
htmlDescription: Assignment.GetDescriptionHtml(),
canvasAssignmentGroupId: (ulong)canvasAssignmentGroupId
);
}

View File

@@ -31,7 +31,7 @@ public class QuizEditorContext
get => _quiz;
set
{
if (_quiz == null && value != null)
if (_quiz == null && value != null && planner != null && planner.LocalCourse != null)
{
_module = getCurrentLocalModule(value, planner.LocalCourse);
}

View File

@@ -24,7 +24,6 @@ public static partial class AssignmentSyncronizationExtensions
var canvasAssignment = canvasAssignments.FirstOrDefault(
ca => ca.Name == localAssignment.Name
);
string localHtmlDescription = localAssignment.GetDescriptionHtml();
var canvasAssignmentGroupId = localAssignment.GetCanvasAssignmentGroupId(localCourse.Settings.AssignmentGroups);
@@ -35,10 +34,9 @@ public static partial class AssignmentSyncronizationExtensions
localAssignment,
canvasAssignment,
canvas,
localHtmlDescription,
canvasAssignmentGroupId
)
: await canvas.Assignments.Create(canvasCourseId, localAssignment, localHtmlDescription, canvasAssignmentGroupId);
: await canvas.Assignments.Create(canvasCourseId, localAssignment, canvasAssignmentGroupId);
}
private static async Task<ulong> updateAssignmentIfNeeded(
@@ -47,7 +45,6 @@ public static partial class AssignmentSyncronizationExtensions
LocalAssignment localAssignment,
CanvasAssignment canvasAssignment,
CanvasService canvas,
string localHtmlDescription,
ulong? canvasAssignmentGroupId
)
{
@@ -63,8 +60,7 @@ public static partial class AssignmentSyncronizationExtensions
courseId: canvasCourseId,
canvasAssignmentId: canvasAssignment.Id,
localAssignment,
localHtmlDescription,
(ulong)canvasAssignmentGroupId
canvasAssignmentGroupId
);
}
return canvasAssignment.Id;