adding file name validation

src/features/local/assignments/assignmentRouter.ts

@@ -10,6 +10,7 @@ import { getCoursePathByName } from "../globalSettings/globalSettingsFileStorage
 import { promises as fs } from "fs";
 import { courseItemFileStorageService } from "../course/courseItemFileStorageService";
 import { assignmentMarkdownSerializer } from "./models/utils/assignmentMarkdownSerializer";
+import { assertValidFileName } from "@/services/fileNameValidation";
 
 export const assignmentRouter = router({
   getAssignment: publicProcedure
@@ -133,16 +134,7 @@ export async function updateOrCreateAssignmentFile({
   assignmentName: string;
   assignment: LocalAssignment;
 }) {
-  const illegalCharacters = ["<", ">", ":", '"', "/", "\\", "|", "?", "*"];
-  const foundIllegalCharacters = illegalCharacters.filter((char) =>
-    assignmentName.includes(char)
-  );
-  if (foundIllegalCharacters.length > 0) {
-    throw new Error(
-      `"${assignmentName}" cannot contain the following characters: ${foundIllegalCharacters.join(
-        " "
-      )}`
-    );
+  assertValidFileName(assignmentName);
   }
 
   const courseDirectory = await getCoursePathByName(courseName);

src/features/local/pages/pageRouter.ts

@@ -1,11 +1,16 @@
 import publicProcedure from "../../../services/serverFunctions/publicProcedure";
 import { z } from "zod";
 import { router } from "../../../services/serverFunctions/trpcSetup";
-import { LocalCoursePage, localPageMarkdownUtils, zodLocalCoursePage } from "@/features/local/pages/localCoursePageModels";
+import {
+  LocalCoursePage,
+  localPageMarkdownUtils,
+  zodLocalCoursePage,
+} from "@/features/local/pages/localCoursePageModels";
 import { courseItemFileStorageService } from "../course/courseItemFileStorageService";
 import { promises as fs } from "fs";
 import path from "path";
 import { getCoursePathByName } from "../globalSettings/globalSettingsFileStorageService";
+import { assertValidFileName } from "@/services/fileNameValidation";
 
 export const pageRouter = router({
   getPage: publicProcedure
@@ -115,31 +120,32 @@ export const pageRouter = router({
 });
 
 export async function updatePageFile({
-    courseName,
+  courseName,
+  moduleName,
+  pageName,
+  page,
+}: {
+  courseName: string;
+  moduleName: string;
+  pageName: string;
+  page: LocalCoursePage;
+}) {
+  assertValidFileName(pageName);
+  const courseDirectory = await getCoursePathByName(courseName);
+  const folder = path.join(courseDirectory, moduleName, "pages");
+  await fs.mkdir(folder, { recursive: true });
+
+  const filePath = path.join(
+    courseDirectory,
     moduleName,
-    pageName,
-    page,
-  }: {
-    courseName: string;
-    moduleName: string;
-    pageName: string;
-    page: LocalCoursePage;
-  }) {
-    const courseDirectory = await getCoursePathByName(courseName);
-    const folder = path.join(courseDirectory, moduleName, "pages");
-    await fs.mkdir(folder, { recursive: true });
+    "pages",
+    pageName + ".md"
+  );
 
-    const filePath = path.join(
-      courseDirectory,
-      moduleName,
-      "pages",
-      pageName + ".md"
-    );
-
-    const pageMarkdown = localPageMarkdownUtils.toMarkdown(page);
-    console.log(`Saving page ${filePath}`);
-    await fs.writeFile(filePath, pageMarkdown);
-  }
+  const pageMarkdown = localPageMarkdownUtils.toMarkdown(page);
+  console.log(`Saving page ${filePath}`);
+  await fs.writeFile(filePath, pageMarkdown);
+}
 async function deletePageFile({
   courseName,
   moduleName,

src/features/local/quizzes/quizRouter.ts

@@ -10,6 +10,7 @@ import path from "path";
 import { promises as fs } from "fs";
 import { quizMarkdownUtils } from "./models/utils/quizMarkdownUtils";
 import { courseItemFileStorageService } from "../course/courseItemFileStorageService";
+import { assertValidFileName } from "@/services/fileNameValidation";
 
 export const quizRouter = router({
   getQuiz: publicProcedure
@@ -149,6 +150,7 @@ export async function updateQuizFile({
   quizName: string;
   quiz: LocalQuiz;
 }) {
+  assertValidFileName(quizName);
   const courseDirectory = await getCoursePathByName(courseName);
   const folder = path.join(courseDirectory, moduleName, "quizzes");
   await fs.mkdir(folder, { recursive: true });