remove nesting options within options

This commit is contained in:
Adam Teichert
2025-12-17 16:49:52 -07:00
parent 7bb276d52a
commit 712a3e5155
3 changed files with 8 additions and 12 deletions

View File

@@ -7,7 +7,7 @@ export const zodGlobalSettingsCourse = z.object({
export const zodGlobalSettings = z.object({
courses: z.array(zodGlobalSettingsCourse),
options: z.record(z.any()).optional(),
feedbackDelims: z.record(z.string()).optional(),
});

View File

@@ -36,12 +36,10 @@ describe("getFeedbackDelimitersFromSettings", () => {
it("returns custom delimiters if options are present", () => {
const settings: GlobalSettings = {
courses: [],
options: {
feedbackDelims: {
neutral: ":|",
correct: ":)",
incorrect: ":(",
},
feedbackDelims: {
neutral: ":|",
correct: ":)",
incorrect: ":(",
},
};
const expected = {
@@ -55,10 +53,8 @@ describe("getFeedbackDelimitersFromSettings", () => {
it("returns mixed delimiters if some options are missing", () => {
const settings: GlobalSettings = {
courses: [],
options: {
feedbackDelims: {
correct: ":)",
},
feedbackDelims: {
correct: ":)",
},
};
const expected = {

View File

@@ -33,7 +33,7 @@ export const getFeedbackDelimitersFromSettings = (
): FeedbackDelimiters => {
return overriddenDefaults(
defaultFeedbackDelimiters,
settings.options?.feedbackDelims ?? {} as Record<string, unknown>
settings.feedbackDelims ?? ({} as Record<string, unknown>)
);
};