From 47c69251c8837af223ee6b98ca47370007e3accf Mon Sep 17 00:00:00 2001 From: Alex Mickelson Date: Wed, 22 Oct 2025 11:52:06 -0600 Subject: [PATCH] fixing multiline feedback --- .../quiz/[quizName]/QuizPreview.tsx | 27 ++++++++++--------- .../quizMarkdown/questionFeedback.test.ts | 1 + .../models/utils/quizFeedbackMarkdownUtils.ts | 3 +++ 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/app/course/[courseName]/modules/[moduleName]/quiz/[quizName]/QuizPreview.tsx b/src/app/course/[courseName]/modules/[moduleName]/quiz/[quizName]/QuizPreview.tsx index 6dbd701..ee4e775 100644 --- a/src/app/course/[courseName]/modules/[moduleName]/quiz/[quizName]/QuizPreview.tsx +++ b/src/app/course/[courseName]/modules/[moduleName]/quiz/[quizName]/QuizPreview.tsx @@ -89,27 +89,30 @@ function QuizQuestionPreview({ question }: { question: LocalQuizQuestion }) {
Feedback
{question.correctComments && ( -
+
+ - - {question.correctComments} - +
)} {question.incorrectComments && ( -
+
- - - {question.incorrectComments} - +
)} {question.neutralComments && ( -
+
... - - {question.neutralComments} - +
)}
diff --git a/src/features/local/parsingTests/quizMarkdown/questionFeedback.test.ts b/src/features/local/parsingTests/quizMarkdown/questionFeedback.test.ts index 5371e3b..18e1e94 100644 --- a/src/features/local/parsingTests/quizMarkdown/questionFeedback.test.ts +++ b/src/features/local/parsingTests/quizMarkdown/questionFeedback.test.ts @@ -319,5 +319,6 @@ essay expect(firstQuestion.questionType).toBe(QuestionType.ESSAY); expect(firstQuestion.text).not.toContain("this is general feedback"); expect(firstQuestion.neutralComments).toBe("this is general feedback"); + expect(firstQuestion.neutralComments).not.toContain("..."); }); }); diff --git a/src/features/local/quizzes/models/utils/quizFeedbackMarkdownUtils.ts b/src/features/local/quizzes/models/utils/quizFeedbackMarkdownUtils.ts index 78fab5d..a5aabfd 100644 --- a/src/features/local/quizzes/models/utils/quizFeedbackMarkdownUtils.ts +++ b/src/features/local/quizzes/models/utils/quizFeedbackMarkdownUtils.ts @@ -70,12 +70,15 @@ export const quizFeedbackMarkdownUtils = { .replace(feedbackIndicators[currentFeedbackType], "") .trim(); comments[currentFeedbackType].push(lineWithoutIndicator); + } else if (lineFeedbackType !== "none") { + const lineWithoutIndicator = line .replace(feedbackIndicators[lineFeedbackType], "") .trim(); currentFeedbackType = lineFeedbackType; comments[lineFeedbackType].push(lineWithoutIndicator); + } else { otherLines.push(line); }